linux-kernel - Re: [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 May 2015 21:09:27 +0900
From:	Krzysztof Kozłowski <k.kozlowski.k@...il.com>
To:	Anda-Maria Nicolae <anda-maria.nicolae@...el.com>
Cc:	sre@...nel.org, dbaryshkov@...il.com, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	dwmw2@...radead.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger

2015-05-08 20:58 GMT+09:00 Anda-Maria Nicolae <anda-maria.nicolae@...el.com>:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 4091fb0..b2b230c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -439,6 +439,13 @@ config BATTERY_RT5033
>           The fuelgauge calculates and determines the battery state of charge
>           according to battery open circuit voltage.
>
> +config CHARGER_RT9455
> +       tristate "Richtek RT9455 battery charger driver"
> +       depends on I2C && GPIOLIB
> +       depends on REGMAP_I2C

Like I said previously, I still think you need to select it, not
depend on it. This is not a user-selectable option, so depending on it
may hide your driver. If you are unsure in such case you can always:
$ git grep REGMAP_I2C

Rest looks fine to me, so with the change above (s/depends on/select/):
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/