linux-kernel - Re: [PATCHv6 05/10] ARM: mxs: fix in tree users of ssd1306

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508133138.GS11057@lukather>
Date:	Fri, 8 May 2015 15:31:38 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Shawn Guo <shawn.guo@...aro.org>
Cc:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Thomas Niederprüm <niederp@...sik.uni-kl.de>,
	Sascha Hauer <kernel@...gutronix.de>, plagnioj@...osoft.com,
	robh+dt@...nel.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 05/10] ARM: mxs: fix in tree users of ssd1306

Hi Shawn,

On Thu, May 07, 2015 at 07:28:01PM +0800, Shawn Guo wrote:
> On Thu, May 07, 2015 at 01:55:35PM +0300, Tomi Valkeinen wrote:
> > Hi,
> > 
> > On 31/03/15 21:27, Thomas Niederprüm wrote:
> > > This patch updates the in tree-users of the SSD1306 controller for using
> > > the newly introduced DT properties.
> > > 
> > > Signed-off-by: Thomas Niederprüm <niederp@...sik.uni-kl.de>
> > > ---
> > >  arch/arm/boot/dts/imx28-cfa10036.dts | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts
> > > index b04b6b8..570aa33 100644
> > > --- a/arch/arm/boot/dts/imx28-cfa10036.dts
> > > +++ b/arch/arm/boot/dts/imx28-cfa10036.dts
> > > @@ -99,6 +99,9 @@
> > >  					solomon,height = <32>;
> > >  					solomon,width = <128>;
> > >  					solomon,page-offset = <0>;
> > > +					solomon,com-lrremap;
> > > +					solomon,com-invdir;
> > > +					solomon,com-offset = <32>;
> > >  				};
> > >  			};
> > 
> > Should this patch be merged separately via proper tree? I can take the
> > rest of the patches via fbdev tree. I can, of course, take this via
> > fbdev also, if I get an ack.
> 
> @Maxime
> 
> I assume you're the person, right?

I don't have this board right now to actually test, but the changes
look good.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)