linux-kernel - Re: [PATCH] mips:Remove unneeded duplicate declaration of cpu_callin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <554CCD6D.9010004@imgtec.com>
Date:	Fri, 8 May 2015 15:51:25 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Nicholas Krause <xerofoify@...il.com>, <ralf@...ux-mips.org>
CC:	<chenhc@...ote.com>, <andreas.herrmann@...iumnetworks.com>,
	<rusty@...tcorp.com.au>, <linux-mips@...ux-mips.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mips:Remove unneeded duplicate declaration of cpu_callin_map
 in smp.h

On 08/05/15 15:12, Nicholas Krause wrote:
> This removes the unneeded duplicate declaration of cpu_callin_map
> in smp.h due to use already declaring it in the file,smp.c that

No, it isn't declared in arch/mips/kernel/smp.c, its *defined* there (no
"extern"). It's referenced by:
arch/mips/cavium-octeon/smp.c
arch/mips/kernel/process.c
arch/mips/kernel/smp-bmips.c
arch/mips/kernel/smp-cps.c
arch/mips/loongson/loongson-3/smp.c
as well as arch/mips/kernel/smp.c, which is why the declaration is
needed in a header.

If you're attempting to fix the build errors in this area, please see:
http://patchwork.linux-mips.org/patch/9970/

Cheers
James

> already uses it internally for functions required this variable
> for their various internal work.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/mips/include/asm/smp.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/smp.h b/arch/mips/include/asm/smp.h
> index bb02fac..7752011 100644
> --- a/arch/mips/include/asm/smp.h
> +++ b/arch/mips/include/asm/smp.h
> @@ -45,8 +45,6 @@ extern int __cpu_logical_map[NR_CPUS];
>  #define SMP_DUMP		0x8
>  #define SMP_ASK_C0COUNT		0x10
>  
> -extern volatile cpumask_t cpu_callin_map;
> -
>  /* Mask of CPUs which are currently definitely operating coherently */
>  extern cpumask_t cpu_coherent_mask;
>  
> 


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)