linux-kernel - Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508173737.GA5991@deathray>
Date:	Fri, 8 May 2015 12:37:37 -0500
From:	Michael Welling <mwelling@...e.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS

On Fri, May 08, 2015 at 06:09:16PM +0100, Mark Brown wrote:
> On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote:
> 
> > +	if (gpio_is_valid(spi->cs_gpio)) {
> > +		if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0)
> > +			gpio_direction_output(spi->cs_gpio,
> > +			!(spi->mode & SPI_CS_HIGH));
> > +	}
> 
> I'm not seeing anything that frees this GPIO?

Ooops I forgot to add this to the cleanup function.

It appears that the transfer_one patch got applied so how should I
provide the new version of this patch?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/