linux-kernel - Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-KX_LXxd07ifcTMhm3Qn=QkNK4pwq=hd6HV_wTQgF6X_A@mail.gmail.com>
Date:	Fri, 8 May 2015 10:43:39 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Arnd Bergmann <arnd@...db.de>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device
 properties interface

On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> If GPIOLIB=n:
>
>     drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’:
>     drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’
>     drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast
>
> Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child()
> for the !GPIOLIB case to fix this.
>

Geert,

This patch looks good to me. Do you mind merging it through LED tree
with other 2 more LED patches?

Thanks,
-Bryan


> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Fixes: 40b7318319281b1b ("gpio: Support for unified device properties interface")
> ---
>  include/linux/gpio/consumer.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index 3a7c9ffd5ab930b4..da042657dc31d7f5 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -406,6 +406,21 @@ static inline int desc_to_gpio(const struct gpio_desc *desc)
>         return -EINVAL;
>  }
>
> +/* Child properties interface */
> +struct fwnode_handle;
> +
> +static inline struct gpio_desc *fwnode_get_named_gpiod(
> +       struct fwnode_handle *fwnode, const char *propname)
> +{
> +       return ERR_PTR(-ENOSYS);
> +}
> +
> +static inline struct gpio_desc *devm_get_gpiod_from_child(
> +       struct device *dev, const char *con_id, struct fwnode_handle *child)
> +{
> +       return ERR_PTR(-ENOSYS);
> +}
> +
>  #endif /* CONFIG_GPIOLIB */
>
>  /*
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/