linux-kernel - Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1431054293.3260.7.camel@rzhang1-mobl4>
Date:	Fri, 08 May 2015 11:04:53 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	Anand Moon <linux.amoon@...il.com>,
	Brian Norris <computersforpeace@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Javi Merino <javi.merino@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command

On Thu, 2015-05-07 at 13:31 -0700, Jacob Pan wrote:
> On Fri,  8 May 2015 03:39:04 +0930
> Anand Moon <linux.amoon@...il.com> wrote:
> 
> > To install tmon we issue "make install" which produces bellow error.
> > 
> looks good, there is no config file for now.
> 
> Thanks for the fix.
> Acked-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> 
patch applied. Thanks!

BTW, next time when sending a thermal related change, please cc
linux-pm@...r.kernel.org, or else the change may got because we usually
rely on https://patchwork.kernel.org/project/linux-pm/list/ to review
and scrub the patches. :)

thanks,
rui



> > root@...oidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> > make install mkdir -p /usr/bin
> > install -m 755 -p "tmon" "/usr/bin/tmon"
> > mkdir -p /
> > install -m 644 -p "" "/"
> > install: cannot stat ‘’: No such file or directory
> > make: [install] Error 1 (ignored)
> > 
> > Signed-off-by: Anand Moon <linux.amoon@...il.com>
> > ---
> >  tools/thermal/tmon/Makefile | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> > index 0788621..2e83dd3 100644
> > --- a/tools/thermal/tmon/Makefile
> > +++ b/tools/thermal/tmon/Makefile
> > @@ -12,10 +12,6 @@ TARGET=tmon
> >  INSTALL_PROGRAM=install -m 755 -p
> >  DEL_FILE=rm -f
> >  
> > -INSTALL_CONFIGFILE=install -m 644 -p
> > -CONFIG_FILE=
> > -CONFIG_PATH=
> > -
> >  # Static builds might require -ltinfo, for instance
> >  ifneq ($(findstring -static, $(LDFLAGS)),)
> >  STATIC := --static
> > @@ -38,13 +34,9 @@ valgrind: tmon
> >  install:
> >  	- mkdir -p $(INSTALL_ROOT)/$(BINDIR)
> >  	- $(INSTALL_PROGRAM) "$(TARGET)"
> > "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > -	- mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> > -	- $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> > "$(INSTALL_ROOT)/$(CONFIG_PATH)" 
> >  uninstall:
> >  	$(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > -	$(CONFIG_FILE) "$(CONFIG_PATH)"
> > -
> >  
> >  clean:
> >  	find . -name "*.o" | xargs $(DEL_FILE)
> 
> [Jacob Pan]


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/