lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1431120710.5136.12.camel@j-VirtualBox>
Date:	Fri, 08 May 2015 14:31:50 -0700
From:	Jason Low <jason.low2@...com>
To:	Fengguang Wu <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	torvalds@...ux-foundation.org, Waiman.Long@...com, bp@...en8.de,
	mingo@...nel.org, preeti@...ux.vnet.ibm.com, fweisbec@...il.com,
	rostedt@...dmis.org, paulmck@...ux.vnet.ibm.com, riel@...hat.com,
	mgorman@...e.de, hpa@...or.com, aswin@...com,
	umgwanakikbuti@...il.com, akpm@...ux-foundation.org,
	oleg@...hat.com, scott.norton@...com, dave@...olabs.net,
	tglx@...utronix.de
Cc:	linux-tip-commits@...r.kernel.org
Subject: [PATCH] sched, timer: Fix documentation for 'struct
 thread_group_cputimer'

On Fri, 2015-05-08 at 06:22 -0700, tip-bot for Jason Low wrote:
> Commit-ID:  1018016c706f7ff9f56fde3a649789c47085a293
> Gitweb:     http://git.kernel.org/tip/1018016c706f7ff9f56fde3a649789c47085a293
> Author:     Jason Low <jason.low2@...com>
> AuthorDate: Tue, 28 Apr 2015 13:00:22 -0700
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Fri, 8 May 2015 12:15:31 +0200
> 
> sched, timer: Replace spinlocks with atomics in thread_group_cputimer(), to improve scalability

The following patch addresses the issue reported by Fengguang Wu
regarding this tip commit 1018016c706f.

---------------------------------------------------------------------------
The description for struct thread_group_cputimer contains the 'cputime'
and 'lock' members, which are not valid anymore since

  tip commit 1018016c706f ("sched, timer: Replace spinlocks with atomics
  in thread_group_cputimer(), to improve scalability")

modified/removed those fields. This patch updates the description
to reflect those changes.

Reported-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Jason Low <jason.low2@...com>
---
 include/linux/sched.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 6cc4f7e..cb73486 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -606,10 +606,9 @@ struct task_cputime_atomic {
 
 /**
  * struct thread_group_cputimer - thread group interval timer counts
- * @cputime:		thread group interval timers.
+ * @cputime_atomic:	atomic thread group interval timers.
  * @running:		non-zero when there are timers running and
  * 			@cputime receives updates.
- * @lock:		lock for fields in this struct.
  *
  * This structure contains the version of task_cputime, above, that is
  * used for thread group CPU timer calculations.
-- 
1.7.2.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ