linux-kernel - Re: [PATCH] staging: gdm724: adding kernel endianness header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150509105940.GE14154@mwanda>
Date:	Sat, 9 May 2015 13:59:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jaime Arrocha <jarr@...neldev.net>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	deanahn@...semi.com, jonathankim@...semi.com,
	linux-kernel@...r.kernel.org, jarrocha@...ux.com
Subject: Re: [PATCH] staging: gdm724: adding kernel endianness header

On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> >From TODO list: remove test for host endian
> Included header to gather information about host endianness.
> Please let me know if the code addition requires corrections
> to meet standards.
> 

No.  This isn't really an improvement.  We need to get rid of ->host_ed
entirely.  Which is actually easy.  Basically change gdm_cpu_to_dev16()
and friends to do so something:

u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
{
	if (ed->dev_ed == ENDIANNESS_LITTLE)
		return cpu_to_le16(x);
	else
		return cpu_to_be16(x);
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/