linux-kernel - Re: [PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 May 2015 22:10:57 +0300
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Martin Liška <marxin.liska@...il.com>,
	Marek Vašut <marex@...x.de>,
	rui.zhang@...el.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor

On Sat, May 9, 2015 at 9:45 PM, Gabriele Mazzotta
<gabriele.mzt@...il.com> wrote:
> On Saturday 02 May 2015 14:30:57 Gabriele Mazzotta wrote:
>> This driver adds the initial support for the ACPI Ambient Light Sensor
>> as defined in Section 9.2 of the ACPI specification (Revision 5.0) [1].
>>
>> Sensors complying with the standard are exposed as ACPI devices with
>> ACPI0008 as hardware ID and provide standard methods by which the OS
>> can query properties of the ambient light environment the system is
>> currently operating in.
>>
>> This driver currently allows only to get the current ambient light
>> illuminance reading through the _ALI method, but is ready to be
>> extended extended to handle _ALC, _ALT and _ALP as well.
>>
>> [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
>>
>> Signed-off-by: Martin Liska <marxin.liska@...il.com>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
>> Cc: Zhang Rui <rui.zhang@...el.com>
>> ---
>> Changes since v8:
>>  - Set realbits to 32
>>  - Fix license mismatch (using GPL v2 or later)
>>  - Drop iio_device_unregister() in favor of devm_iio_device_register()
>>
>>  drivers/iio/light/Kconfig    |  12 +++
>>  drivers/iio/light/Makefile   |   1 +
>>  drivers/iio/light/acpi-als.c | 232 +++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 245 insertions(+)
>>  create mode 100644 drivers/iio/light/acpi-als.c
>>
>> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
>> index 01a1a16..898b2b5 100644
>> --- a/drivers/iio/light/Kconfig
>> +++ b/drivers/iio/light/Kconfig
>> @@ -5,6 +5,18 @@
>>
>>  menu "Light sensors"
>>
>> +config ACPI_ALS
>> +     tristate "ACPI Ambient Light Sensor"
>> +     depends on ACPI
>
> I'm sorry, but I've just noticed that here there should also be
>
>         select IIO_BUFFER
>
> I hope it's not too late and I can resend this patch if needed.

You can send a patch on top of the previous one. Eventually, Jonathan
will squash them.

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/