linux-kernel - Re: [PATCH 2/3] perf report: Force tty output if -T/--thread option is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 May 2015 14:16:58 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 2/3] perf report: Force tty output if -T/--thread option
 is given

Em Sun, May 10, 2015 at 12:19:43AM +0900, Namhyung Kim escreveu:
> The -T/--thread option is supported only on --stdio mode (at least for
> now).  So enforce the tty output if the option was requested.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-report.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index b63aeda719be..ee541ad555f2 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -803,8 +803,8 @@ repeat:
>  		goto error;
>  	}
>  
> -	/* Force tty output for header output. */
> -	if (report.header || report.header_only)
> +	/* Force tty output for header output and per-thread stat. */
> +	if (report.header || report.header_only || report.show_threads)
>  		use_browser = 0;

I will apply, but please consider sending a followup patch to emit a
warning for the cases when --tui or --gtk is explicitely passed, i.e.
emit a warning saying that that is not possible.

- Arnaldo

>  
>  	if (strcmp(input_name, "-") != 0)
> -- 
> 2.3.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/