linux-kernel - Re: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150510.175057.1320510115648828229.davem@davemloft.net>
Date:	Sun, 10 May 2015 17:50:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kys@...rosoft.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	jasowang@...hat.com
Subject: Re: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag
 to optimize signaling the host

From: "K. Y. Srinivasan" <kys@...rosoft.com>
Date: Wed,  6 May 2015 15:29:05 -0700

> -		ret = vmbus_sendpacket_pagebuffer(out_channel,
> -						  pgbuf,
> -						  packet->page_buf_cnt,
> -						  &nvmsg,
> -						  sizeof(struct nvsp_message),
> -						  req_id);
> +		ret = vmbus_sendpacket_pagebuffer_ctl(out_channel,
> +						      pgbuf,
> +						      packet->page_buf_cnt,
> +						      &nvmsg,
> +						      sizeof(struct
> +							     nvsp_message),
> +						      req_id,
> +						      vmbus_flags,
> +						      !packet->xmit_more);
>  	} else {
> -		ret = vmbus_sendpacket(
> +		ret = vmbus_sendpacket_ctl(
>  				out_channel, &nvmsg,
>  				sizeof(struct nvsp_message),
>  				req_id,
>  				VM_PKT_DATA_INBAND,
> -				VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
> +				vmbus_flags, !packet->xmit_more);

Just as you did for the vmbus_sendpacket_pagebuffer_ctl() call above,
you'll need to reindent the arguments for the vmbus_sendpacket_ctl()
call since the openning parenthesis is now at a different column.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/