linux-kernel - Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150510101750.GC11057@lukather>
Date:	Sun, 10 May 2015 12:17:50 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Vishnu Patekar <vishnupatekar0510@...il.com>
Cc:	emilio@...pez.com.ar, linus.walleij@...aro.org, robh+dt@...nel.org,
	hdegoede@...hat.com, wens@...e.org, jenskuske@...il.com,
	arnd@...db.de, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation

Hi,

On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote:
> A33 clock control unit is similar to A23.
> 
> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE
> to get it compiled for A33.

That commit log doesn't make any sense.

What you're doing isn't about whether or not that will be compiled,
but whether you're registering the clocks and which clocks you
protect.

> Signed-off-by: VishnuPatekar <vishnupatekar0510@...il.com>

Isn't it supposed to have a space in the middle of your name, just
like you have in your mail address?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)