linux-kernel - perf tools: Event naming inconsistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150511191614.GB5456@kernel.org>
Date:	Mon, 11 May 2015 16:16:14 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Namhyung Kim <namhyung@...il.com>, David Ahern <dsahern@...il.com>
Subject: perf tools: Event naming inconsistency

Hi Jiri,

	Noticed this while testing the PERF_RECORD_LOST_SAMPLES
patchkit:

[root@zoo ~]# perf record -e '{cycles,instructions}:p' usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ]
[root@zoo ~]# perf record -e '{cycles:p,instructions:p}' usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ]
[root@zoo ~]#

Thse should be equivalent, right?

If I do:

[root@zoo ~]# perf evlist -i perf.data.old
cycles
instructions
[root@zoo ~]# perf evlist -i perf.data
cycles:p
instructions:p
[root@zoo ~]#

But:

[root@zoo ~]# perf evlist -v -i perf.data.old
cycles: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
instructions: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1
[root@zoo ~]#

[root@zoo ~]# perf evlist -v -i perf.data
cycles:p: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
instructions:p: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1
[root@zoo ~]# 

Both are exactly the same, would be nice that tooling when showing both
cases showed the same event name, to avoid confusion... Anyway, not that
high prio ;-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/