linux-kernel - Re: [PATCH 1/6] clk: asm9260: Fix of_io_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511194336.GH10961@lukather>
Date:	Mon, 11 May 2015 21:43:36 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	linux-kernel@...r.kernel.org
Cc:	Mike Turquette <mturquette@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>, linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/6] clk: asm9260: Fix of_io_request_and_map error check

Mike, Stephen,

On Sat, May 02, 2015 at 05:03:21PM +0200, Maxime Ripard wrote:
> of_io_request_and map returns an error pointer, but the current code assumes
> that on error the returned pointer will be NULL.
> 
> Obviously, that makes the check completely useless. Change the test to actually
> check for the proper error code.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Mike Turquette <mturquette@...aro.org>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: linux-clk@...r.kernel.org

There doesn't seem to be a sub-maintainer for that driver, I guess it
should go through your tree?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)