linux-kernel - Re: [PATCH v4 3/3] perf probe: Show better error message when failed to find variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55510FA5.8080805@hitachi.com>
Date:	Tue, 12 May 2015 05:23:01 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	He Kuang <hekuang@...wei.com>, a.p.zijlstra@...llo.nl,
	acme@...nel.org, jolsa@...nel.org, mingo@...hat.com
CC:	wangnan0@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] perf probe: Show better error message when
 failed to find variable

On 2015/05/11 22:10, He Kuang wrote:
> Indicate to check variable location range in error message when we got
> failed to find the variable, and put user-supplied variable name in
> quotes.
> 
> Before this patch:
> 
>   $ perf probe --add 'generic_perform_write+118 bytes'
>   Failed to find the location of bytes at this address.
>    Perhaps, it has been optimized out.
>     Error: Failed to add events.
> 
> After this patch:
>   $ perf probe --add 'generic_perform_write+118 bytes'
>   Failed to find the location of the 'bytes' variable at this address.
>    Perhaps, it has been optimized out.
>    Use -V with --range option to show variable location range.
>     Error: Failed to add events.
> 

Looks good to me :)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

Anraldo, could you replace this with v3? This patch has actual change
to fix my easy to mislead message ...

> Signed-off-by: He Kuang <hekuang@...wei.com>
> ---
>  tools/perf/util/probe-finder.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index f032329..0fc2ae8 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -528,8 +528,10 @@ static int convert_variable(Dwarf_Die *vr_die, struct probe_finder *pf)
>  	ret = convert_variable_location(vr_die, pf->addr, pf->fb_ops,
>  					&pf->sp_die, pf->tvar);
>  	if (ret == -ENOENT || ret == -EINVAL)
> -		pr_err("Failed to find the location of %s at this address.\n"
> -		       " Perhaps, it has been optimized out.\n", pf->pvar->var);
> +		pr_err("Failed to find the location of the '%s' variable at this address.\n"

This line is new.

> +		       " Perhaps, it has been optimized out.\n"
> +		       " Use -V with --range option to show variable location range.\n",
> +		       pf->pvar->var);
>  	else if (ret == -ENOTSUP)
>  		pr_err("Sorry, we don't support this variable location yet.\n");
>  	else if (ret == 0 && pf->pvar->field) {
> 

Thank you,

-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/