linux-kernel - Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 23:01:22 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Michal Hocko <mhocko@...e.cz>,
	Vladimir Davydov <vdavydov@...allels.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andy Lutomirski <luto@...capital.net>,
	Bertrand Jacquin <beber@...eeweb.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Iulia Manda <iulia.manda21@...il.com>,
	Pranith Kumar <bobby.prani@...il.com>,
	Clark Williams <clark.williams@...il.com>,
	Mel Gorman <mgorman@...e.de>,
	Randy Dunlap <rdunlap@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate
 file, init/Kconfig.expert

On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote:
> I'd also like to factor the "if EXPERT" off of all the prompts and into a
> single scoped item wrapped around all of them, but kconfig doesn't have any way
> to do that.  "menuconfig" is just a hint, with no matching "endmenu" and no
> implicit visibility; "menu" is scoped and has "visible if", but that would
> create a separate option containing a menu, rather than a menu under EXPERT's
> "Configure standard kernel features (expert users)".  And "if EXPERT ... endif"
> produces a dependency, not a prompt-visibility condition.  So I think this
> would require changes to the Kconfig language, to introduce either a scoped
> "visible if EXPERT ... endvisible" or similar, or a scoped version of
> menuconfig with a matching "endmenu" and implicit visibility (effectively a
> "menu" statement with attached "config" rather than a "config" with a hint
> "this might be a menu").  I'm leaning towards the latter.

The behavior of menuconfig in this case is rather subtle. I must admit I
never noticed it.

The "visible" option to menus is little used, and I'm not really
familiar with it. So, for what it's worth: would adding a new menu with
	visible if EXPERT

attached to it, and putting all current
	prompt "Foo" if EXPERT

entries in that menu roughly do what you want?

> So I'll send a followup patch enhancing kconfig to improve this case,
> but I think splitting this into a separate file is still worth it even
> without that.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/