linux-kernel - Re: [PATCH] x86: Preserve iopl on fork and execve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150511220914.7b841848@lxorguk.ukuu.org.uk>
Date:	Mon, 11 May 2015 22:09:14 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Alex Henrie <alexhenrie24@...il.com>
Cc:	Kees Cook <keescook@...omium.org>,
	"H. Peter Anvin" <hpa@...or.com>, Doug Johnson <dougvj@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Tyler Hicks <tyhicks@...onical.com>,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Preserve iopl on fork and execve

On Mon, 11 May 2015 14:49:58 -0600
Alex Henrie <alexhenrie24@...il.com> wrote:

> Signed-off-by: Alex Henrie <alexhenrie24@...il.com>
> Suggested-by: Doug Johnson <dougvj@...gvj.net>
> ---
>  arch/x86/kernel/process_32.c | 2 +-
>  arch/x86/kernel/process_64.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This strikes me as insane.

Existing iopl using code does not expect to accidentally pass the keys to
the empire to any helper apps it spawns. We wouldn't add a new feature
that suddenely gave root to tasks forked from a process that was
expecting the rights to be dropped, so we certainly shouldn't add iopl
on this way.

(I agree the behaviour you suggest was probably preferable, it's just 25
years too late to correct that one)

Yes it makes using iopl harder, but if anything that is good. You really
really must know what you are doing to use iopl, and its really something
only hideous things like legacy PC BIOS flash tools should be touching
and even then very very carefully having used mlockall and while making
no syscalls or page faults with interrupts off.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/