linux-kernel - Re: [PATCH V2 2/2] powerpc/thp: Serialize pmd clear against a linux page table walk.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zj5b4oed.fsf@linux.vnet.ibm.com>
Date:	Mon, 11 May 2015 12:00:18 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mpe@...erman.id.au, paulus@...ba.org, benh@...nel.crashing.org,
	kirill.shutemov@...ux.intel.com, aarcange@...hat.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH V2 2/2] powerpc/thp: Serialize pmd clear against a linux page table walk.

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Thu,  7 May 2015 12:53:28 +0530 "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> wrote:
>
>> Serialize against find_linux_pte_or_hugepte which does lock-less
>> lookup in page tables with local interrupts disabled. For huge pages
>> it casts pmd_t to pte_t. Since format of pte_t is different from
>> pmd_t we want to prevent transit from pmd pointing to page table
>> to pmd pointing to huge page (and back) while interrupts are disabled.
>> We clear pmd to possibly replace it with page table pointer in
>> different code paths. So make sure we wait for the parallel
>> find_linux_pte_or_hugepage to finish.
>
> I'm not seeing here any description of the problem which is being
> fixed.  Does the patch make the machine faster?  Does the machine
> crash?

I sent v3 with updated commit message. Adding that below.

    powerpc/thp: Serialize pmd clear against a linux page table walk.
    
    Serialize against find_linux_pte_or_hugepte which does lock-less
    lookup in page tables with local interrupts disabled. For huge pages
    it casts pmd_t to pte_t. Since format of pte_t is different from
    pmd_t we want to prevent transit from pmd pointing to page table
    to pmd pointing to huge page (and back) while interrupts are disabled.
    We clear pmd to possibly replace it with page table pointer in
    different code paths. So make sure we wait for the parallel
    find_linux_pte_or_hugepage to finish.
    
    Without this patch, a find_linux_pte_or_hugepte running in parallel to
    __split_huge_zero_page_pmd or do_huge_pmd_wp_page_fallback or zap_huge_pmd
    can run into the above issue. With __split_huge_zero_page_pmd and
    do_huge_pmd_wp_page_fallback we clear the hugepage pte before inserting
    the pmd entry with a regular pgtable address. Such a clear need to
    wait for the parallel find_linux_pte_or_hugepte to finish.
    
    With zap_huge_pmd, we can run into issues, with a hugepage pte
    getting zapped due to a MADV_DONTNEED while other cpu fault it
    in as small pages.

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/