linux-kernel - Re: [PATCH v2 04/10] mfd: cros_ec: Use a zero-length array for command data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555124DE.8030003@collabora.co.uk>
Date:	Mon, 11 May 2015 23:53:34 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Heiko Stuebner <heiko@...ech.de>
CC:	Gwendal Grignou <gwendal@...omium.org>,
	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Stephen Barber <smbarber@...omium.org>,
	Filipe Brandenburger <filbranden@...gle.com>,
	Todd Broch <tbroch@...omium.org>,
	Alexandru M Stan <amstan@...omium.org>,
	linux-samsung-soc@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 04/10] mfd: cros_ec: Use a zero-length array for command
 data

Hello Heiko and Alexandru,

On 05/11/2015 11:47 PM, Heiko Stuebner wrote:
>> Heiko, Alexandru,
>> 
>> I don't have access to my Chromebooks right now but could you please test
>> the following patch [0] to see if that is the problem?
>> 
>> It seems I got it working on my test just out of luck since it happened that
>> version was initialized to 0 due the data it was on the stack.
>> 
>> Tomorrow when I've access to the Chromebooks I'll do more extensive testing
>> and see if I can reproduce the issue and if my assumption is correct.
>> 
>> Best regards,
>> Javier
>> 
>> [0]
>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c
>> b/drivers/input/keyboard/cros_ec_keyb.c index ef3ba20f4560..4f233e248a4d
>> 100644
>> --- a/drivers/input/keyboard/cros_ec_keyb.c
>> +++ b/drivers/input/keyboard/cros_ec_keyb.c
>> @@ -151,6 +151,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb
>> *ckdev, uint8_t *kb_state) int ret;
>>  	struct cros_ec_command *msg = (struct cros_ec_command *)kb_state;
>> 
>> +	msg->version = 0;
>>  	msg->command = EC_CMD_MKBP_STATE;
>>  	msg->insize = ckdev->cols;
>>  	msg->outsize = 0;
> 
> on my rk3288-pinky this seems to fix the issue ... keyboard works out of the 
> box again.
>

Thank you both for testing the fix and again sorry for the silly mistake...

I'll wait a couple of days to see if I get more feedback and re-spin a v3
of the series with this fix patch squashed.
 
> 
> Heiko
>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/