linux-kernel - Re: [PATCH 3/3] vTPM: support little endian guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431382048.30108.30.camel@oc8377654763.ibm.com>
Date:	Mon, 11 May 2015 17:07:28 -0500
From:	"Joy M. Latten" <jmlatten@...ux.vnet.ibm.com>
To:	Ashley Lai <ashley@...leylai.com>
Cc:	"Hon Ching(Vicky) Lo" <honclo@...ux.vnet.ibm.com>,
	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <PeterHuewe@....de>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Vicky Lo <honclo2014@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] vTPM: support little endian guests

Hi Ashley,
On Fri, 2015-05-08 at 17:31 -0500, Ashley Lai wrote:
> > The event log in ppc64 arch is always in big endian format. PowerPC
> > supports both little endian and big endian guests. This patch converts
> > the event log entries to guest format.
> 
> I'm a little confused here.  If this patch is to convert the event log 
> entries why are we convert in the conditional statements?  One example 
> below:
> 
> +       if (((convert_to_host_format(event->event_type) == 0) &&
> +            (convert_to_host_format(event->event_size) == 0))
> +           ||
> +           ((v + sizeof(struct tcpa_event) +
> +             convert_to_host_format(event->event_size)) > limit))
> 
Ah, ok... I see what you are saying.. description may be a bit
confusing... we are not converting the event log entries.
We are just making sure that raw integers are correctly interpreted on 
both big and little endian platforms. 
Phype sends info (including logs) in big endian. 
Thus any raw integers in that data, like event_size and 
event_type may become "garbaged" when OS is ppc64-LE. 
This will ensure raw integers are correctly interpreted for both
LE and BE platforms.

> >
> > We defined a macro to convert to guest format. In addition,
> > tpm_binary_bios_measurements_show() is modified to parse the event
> > and print each field individually.
> 
> It's nice to have human readable format but it may break existing tools 
> that parse or understand the machine readable format.  Any comments on 
> this anyone?
> 
Again, description...
We have not changed the format. We are just making sure that raw
integers are correctly interpreted on both big and little endian
platforms for vtpm.

> >>
> > diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c
> > index e77d8c1..1b62c52 100644
> > --- a/drivers/char/tpm/tpm_eventlog.c
> > +++ b/drivers/char/tpm/tpm_eventlog.c
> > @@ -28,6 +28,11 @@
> > #include "tpm.h"
> > #include "tpm_eventlog.h"
> >
> > +#ifdef CONFIG_PPC64
> > +#define convert_to_host_format(x) be32_to_cpu(x)
> > +#else
> > +#define convert_to_host_format(x) x
> > +#endif
> 
> This can go in the header file tpm_eventlog.h
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/