linux-kernel - Re: [PATCH RESEND] mtrr:Remove unnessary included header for the file,main.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150511071524.GA27464@gmail.com>
Date:	Mon, 11 May 2015 09:15:24 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, bp@...e.de, dave.hansen@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] mtrr:Remove unnessary included header for the
 file,main.c


* Nicholas Krause <xerofoify@...il.com> wrote:

> Removes the no longer needed include statement to include the
> header file,linux/types.h due to the header file,kvm_para.h
> no needing this secondary header in order to build successfully
> when being included in other files.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/x86/kernel/cpu/mtrr/main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index ea5f363..049212e 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -33,8 +33,6 @@
>  
>  #define DEBUG
>  
> -#include <linux/types.h> /* FIXME: kvm_para.h needs this */
> -
>  #include <linux/stop_machine.h>
>  #include <linux/kvm_para.h>
>  #include <linux/uaccess.h>

Please don't bother with such churn unless you do more substantial 
work in this area.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/