linux-kernel - Re: rtc: mc13xxx: fix obfuscated and wrong format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150511072615.GK3338@piout.net>
Date:	Mon, 11 May 2015 09:26:15 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: rtc: mc13xxx: fix obfuscated and wrong format string

On 20/02/2015 at 14:47:30 +0100, Rasmus Villemoes wrote :
> According to C99, %2.s means 'print two spaces' (a precision of
> . without following digits or * means 0). The kernel's printf
> implementation, however, treats that case as if no precision was
> given, but relying on that quirk is rather silly. Also, since no -
> (aka left-justify) flag is given, the field with of 2 would then cause
> the alarm->enabled case to come out as "o n". Deobfuscate it.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/rtc/rtc-mc13xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Rebased and applied on rtc-next, thanks.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/