linux-kernel - Re: [PATCH 3/3] UDF: support NFSv2 export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511085741.GA9962@quack.suse.cz>
Date:	Mon, 11 May 2015 10:57:41 +0200
From:	Jan Kara <jack@...e.cz>
To:	NeilBrown <neilb@...e.de>
Cc:	Josef Bacik <jbacik@...com>, Chris Mason <clm@...com>,
	Jan Kara <jack@...e.cz>, David Sterba <dsterba@...e.cz>,
	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>,
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 3/3] UDF: support NFSv2 export

On Fri 08-05-15 10:16:23, NeilBrown wrote:
> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
> that returned by encode_fh - it may be larger.
> 
> With NFSv2, the filehandle is fixed length, so it may appear longer
> than expected and be zero-padded.
> 
> So we must test that fh_len is at least some value, not exactly equal
> to it.
> 
> Signed-off-by: NeilBrown <neilb@...e.de>
  Thanks. The patch looks good to me. I've added it to my tree.

								Honza
> ---
>  fs/udf/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index 5c03f0dfb98b..facc2a840f7b 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -1221,7 +1221,7 @@ static struct dentry *udf_nfs_get_inode(struct super_block *sb, u32 block,
>  static struct dentry *udf_fh_to_dentry(struct super_block *sb,
>  				       struct fid *fid, int fh_len, int fh_type)
>  {
> -	if ((fh_len != 3 && fh_len != 5) ||
> +	if (fh_len < 3 ||
>  	    (fh_type != FILEID_UDF_WITH_PARENT &&
>  	     fh_type != FILEID_UDF_WITHOUT_PARENT))
>  		return NULL;
> @@ -1233,7 +1233,7 @@ static struct dentry *udf_fh_to_dentry(struct super_block *sb,
>  static struct dentry *udf_fh_to_parent(struct super_block *sb,
>  				       struct fid *fid, int fh_len, int fh_type)
>  {
> -	if (fh_len != 5 || fh_type != FILEID_UDF_WITH_PARENT)
> +	if (fh_len < 5 || fh_type != FILEID_UDF_WITH_PARENT)
>  		return NULL;
>  
>  	return udf_nfs_get_inode(sb, fid->udf.parent_block,
> 
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/