linux-kernel - Re: [PATCH v3 3/3] perf probe: Show better error message when failed to find variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511093010.GA31869@gmail.com>
Date:	Mon, 11 May 2015 11:30:10 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	He Kuang <hekuang@...wei.com>
Cc:	masami.hiramatsu.pt@...achi.com, a.p.zijlstra@...llo.nl,
	acme@...nel.org, jolsa@...nel.org, mingo@...hat.com,
	wangnan0@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] perf probe: Show better error message when failed
 to find variable


* He Kuang <hekuang@...wei.com> wrote:

> Indicate to check variable location range in error message when we got
> failed to find the variable.
> 
> Before this patch:
> 
>   $ perf probe --add 'generic_perform_write+118 bytes'
>   Failed to find the location of bytes at this address.
>    Perhaps, it has been optimized out.
>     Error: Failed to add events.
> 
> After this patch:
>   $ perf probe --add 'generic_perform_write+118 bytes'
>   Failed to find the location of bytes at this address.

What does this sentence mean? I thought 'address' means 'location of 
bytes'. So the address identifies the location and obviously we know 
that. So this message wants to say something else.

>    Perhaps, it has been optimized out.
>    Use -V with --range option to show variable location range.

This suggestion is useful.

>     Error: Failed to add events.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/