linux-kernel - Re: [PATCH 0/2 v2] mmc: cast to avoid unexpected error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFq60jNgaY==kEUfUhgPweC22KtA-6dD33mFag1qbzE_pQ@mail.gmail.com>
Date:	Mon, 11 May 2015 12:31:07 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	ryusuke.sakato.bx@...esas.com, yoshihiro.shimoda.uh@...esas.com,
	hiroyuki.yokoyama.vx@...esas.com, takeshi.kihara.df@...esas.com,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Chris Ball <chris@...ntf.net>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	Grégory Soutadé <gsoutade@...tion.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 0/2 v2] mmc: cast to avoid unexpected error

On 11 May 2015 at 09:34, Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
> Hi Ulf
>
> These are v2 of mmc data cast patches which were posted in
> Subject: [PATCH 0/2][RFC] mmc: cast to avoid unexpected error
> Date: Wed, 8 Apr 2015 07:32:35 +0000
>
> These 2 patches adds cast to avoid unexpected error.
> It tries copy to u64 without cast.
> The data will be 0xfff... if last bit was 1.
> These are reported by coverity tool.
> I'm happy if someone tests it, or can get deep review.
>
> Kuninori Morimoto (2):
>       mmc: cast u8 to unsigned long long to avoid unexpected error
>       mmc: cast unsigned int to typeof(sector_t) to avoid unexpected error
>
>  drivers/mmc/card/block.c | 2 +-
>  drivers/mmc/core/mmc.c   | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)

Thanks, applied!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/