linux-kernel - Re: [PATCH RESEND v5 0/2] x86/earlyprintk: setup earlyprintk as early as possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 13:39:13 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Borislav Petkov <bp@...e.de>,
	Mark Rustad <mark.d.rustad@...el.com>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH RESEND v5 0/2] x86/earlyprintk: setup earlyprintk as
 early as possible

On Mon, 2015-05-11 at 16:08 +0600, Alexander Kuleshov wrote:
> The early_printk function is usable after setup_early_printk will be executed. We
> pass 'earlyprintk' through the kernel command line. It means that earlyprintk
> will be usable only after the 'parse_early_param' will be executed. So we have
> usable earlyprintk only during early boot, kernel decompression and after call
> of the 'parse_early_param'. This patchset makes earlyprintk usable before the
> call of the 'parse_early_param'.

Better, though it would be good if native speaker fixes the wording.

P.S. Don't resend version too fast (wait for maybe couple of days for
others to give their comments). Actually this one must be v6, but you
may use that number in next iteration.

> 
> These patchset provides two patches:
> 
> 1. Move handling of the builtin command line to the separate function
> from the setup_arch. Now we can call it from the arch/x86/kernel/head{32,64}.c,
> and find 'earlyprintk' kernel command line paramter there.
> 
> 2. Provide setup_serial_console function to setup serial earlyprintk in the
> arch/x86/kernel/head{32,64}.c
> 
> Changes v5:
> 
> * Call setup_builtin_cmdline instead of setup_cmdline
> 
> Changes v4:
> 
> * Move setup_early_serial_console from the include/linux/printk.h
> to the arch/x86/include/asm/serial.h, because this function is only
> for x86 now.
> 
> Changes v3:
> 
> * Call setup_cmdline before setup_early_printk;
> * setup_early_printk call wrapped with the setup_early_serial_console which
> checks that 'serial' given to the earlyprintk command line option. This
> prevents call of the setup_early_printk with the given pciserial/dbgp/efi,
> because they are using early_ioremap.
> 
> Changes v2:
> 
> * Comment added before the setup_early_printk call;
> * Added information about testing to the commit message.
> 
> Alexander Kuleshov (2):
>   x86/setup: update boot_command_line with builtin_cmdline in separate
>     function
>   x86/earlyprintk: setup earlyprintk as early as possible
> 
>  arch/x86/include/asm/serial.h  |  2 ++
>  arch/x86/include/asm/setup.h   |  3 ++-
>  arch/x86/kernel/early_printk.c | 25 +++++++++++++++++++++++++
>  arch/x86/kernel/head32.c       |  6 ++++++
>  arch/x86/kernel/head64.c       |  7 +++++++
>  arch/x86/kernel/setup.c        | 28 +++++++++++++++-------------
>  6 files changed, 57 insertions(+), 14 deletions(-)
> 


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/