lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5550919A.9090703@collabora.co.uk>
Date:	Mon, 11 May 2015 13:25:14 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Michal Suchanek <hramrach@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Andreas Faerber <afaerber@...e.de>,
	Sachin Kamat <sachin.kamat@...sung.com>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: exynos_defconfig: add options to make wifi usable

Hello Michal,

On 05/11/2015 12:22 PM, Michal Suchanek wrote:
> The Exynos defconfig includes mwifiex sdio support which is present on
> some of the Exynos boards.
> 
> For the WiFi to be usable two extra options are needed. Usermode

Your subject line and the commit message are somehow misleading since
these options are needed to make the WiFi usable with your current setup.

> firmware helper to load out-of-kernel firmware and wireless extensions

For example, this is only needed if the in-kernel fw loader is not
able to find the firmware but isn't needed if the fw is for example
in an initial ramdisk and the kernel is able to load it, built in the
kernel or if the mwifiex driver is built as a module.

> so the interface can be configured with wireless-tools.
>

And wireless extensions is deprecated AFAIK and is only needed for old
user-space since most tools should had been converted to use the netlink
based CONFIG_CFG80211 interface instead.

I'm booting a debian jessie and have WiFi working without CFG80211_WEXT
for example.

That doesn't mean that I'm against your patch (I'm always happy to enable
more config options if that makes the defconfig more useful) but the commit
message should be accurate about why a change has to be done.

> Signed-off-by: Michal Suchanek <hramrach@...il.com>
> ---

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ