linux-kernel - Re: [PATCH] staging: lustre: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511114330.GA11994@sudip-PC>
Date:	Mon, 11 May 2015 17:13:53 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	HPDD-discuss@...1.01.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: remove unused variable

On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
> > -	if (set->set_pga) {
> > -		int len = set->set_oabufs * sizeof(*set->set_pga);
> > +	if (set->set_pga)
> >  		OBD_FREE_LARGE(set->set_pga, len);
>                                              ^^^
> It's used right here?

oops.. sorry .. but why i didnot get a build failure after this?

ok, got it ...  

#define OBD_FREE_LARGE(ptr, size)	\
do {					\
		kvfree(ptr);		\
} while (0)

the variable is actually not used. I will make a v2 and send 
tomorrow. today is a day of silly mistakes :( 

regards
sudip

> 
> regards,
> dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/