linux-kernel - Re: [PATCH] imx27: dt: only map 1 Kbyte for fec registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 20:01:01 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	shawn.guo@...aro.org, kernel@...gutronix.de, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] imx27: dt: only map 1 Kbyte for fec registers

On Sat, May 09, 2015 at 10:54:30PM +0200, Philippe Reynes wrote:
> According to the imx27 documentation, fec has a 1 Kbyte
> memory space map, spitted in two regions of 512 bytes.
> The first one for control/status registers, and the
> second one for event/statistic registers. So, we don't
> need to map 16 Kbyte for registers, 1 Kbyte is enough.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
>  arch/arm/boot/dts/imx27.dtsi |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 6951b66..56bb917 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -533,7 +533,7 @@
>  
>  			fec: ethernet@...2b000 {
>  				compatible = "fsl,imx27-fec";
> -				reg = <0x1002b000 0x4000>;
> +				reg = <0x1002b000 0x400>;

No.  Per MCIMX27RM.pdf, Table 2-7. AIPI2 Memory Map, it should be 4KiB.

Shawn

>  				interrupts = <50>;
>  				clocks = <&clks IMX27_CLK_FEC_IPG_GATE>,
>  					 <&clks IMX27_CLK_FEC_AHB_GATE>;
> -- 
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/