linux-kernel - Re: [RESEND PATCH] Smack: ignore private inode for smack_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5550B73F.8010305@schaufler-ca.com>
Date:	Mon, 11 May 2015 07:05:51 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	sw0312.kim@...sung.com
CC:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, sumit.semwal@...aro.org,
	linaro-mm-sig@...ts.linaro.org
Subject: Re: [RESEND PATCH] Smack: ignore private inode for smack_file_receive

On 5/11/2015 1:12 AM, Seung-Woo Kim wrote:
> Ping?

It's in my queue for 4.2.

>
> On 2015Гт 04Пљ 17РЯ 15:25, Seung-Woo Kim wrote:
>> The dmabuf fd can be shared between processes via unix domain
>> socket. The file of dmabuf fd is came from anon_inode. The inode
>> has no set and get xattr operations, so it can not be shared
>> between processes with smack. This patch fixes just to ignore
>> private inode including anon_inode for smack_file_receive.
>>
>> Signed-off-by: Seung-Woo Kim <sw0312.kim@...sung.com>
>> ---
>> I think there was some issue sending my previous mail, so I resend patch again.
>> ---
>>  security/smack/smack_lsm.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
>> index 69fdc38..d1bb411 100644
>> --- a/security/smack/smack_lsm.c
>> +++ b/security/smack/smack_lsm.c
>> @@ -1673,6 +1673,9 @@ static int smack_file_receive(struct file *file)
>>  	struct smk_audit_info ad;
>>  	struct inode *inode = file_inode(file);
>>  
>> +	if (unlikely(IS_PRIVATE(inode)))
>> +		return 0;
>> +
>>  	smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
>>  	smk_ad_setfield_u_fs_path(&ad, file->f_path);
>>  	/*
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/