linux-kernel - Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150511.104121.111988027007099988.davem@davemloft.net>
Date:	Mon, 11 May 2015 10:41:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kys@...rosoft.com
Cc:	joe@...ches.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, jasowang@...hat.com
Subject: Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to
 optimize signaling the host

From: KY Srinivasan <kys@...rosoft.com>
Date: Mon, 11 May 2015 08:59:53 +0000

> 
> 
>> -----Original Message-----
>> From: Joe Perches [mailto:joe@...ches.com]
>> Sent: Sunday, May 10, 2015 10:58 PM
>> To: KY Srinivasan
>> Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
>> kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
>> apw@...onical.com; jasowang@...hat.com
>> Subject: Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to
>> optimize signaling the host
>> 
>> On Sun, 2015-05-10 at 21:08 -0700, K. Y. Srinivasan wrote:
>> > Based on the information given to this driver (via the xmit_more skb flag),
>> > we can defer signaling the host if more packets are on the way. This will
>> help
>> > make the host more efficient since it can potentially process a larger batch
>> of
>> > packets. Implement this optimization.
>> 
>> trivia:
>> 
>> I think that indirecting
>> VMBUS_DATA_PACKET_FLAG_COMPLETTION_REQUESTED
>> into a non-const temporary isn't very useful.
>> 
>> Whenever overly long identifiers like VMBUS_<FOO> is used,
>> I think that it'd be better to use it directly and ignore
>> 80 column warnings.
> 
> Thanks Joe; if Dave agrees, I can send v6 of this patch out.

Sure, respin a v6.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/