[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1431357059-29795-1-git-send-email-hofrat@osadl.org>
Date: Mon, 11 May 2015 17:10:59 +0200
From: Nicholas Mc Guire <hofrat@...dl.org>
To: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc: Josh Triplett <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <laijs@...fujitsu.com>,
linux-kernel@...r.kernel.org, Nicholas Mc Guire <hofrat@...dl.org>
Subject: [PATCH V2] rcu: change function declaration to bool
rcu_cpu_has_callbacks() is declared int but is actually returning bool and
and as the function description states " * Return true if the specified
CPU has any callback....", this probably should be a bool. All (3)
call-sites currently treat it as bool so the declaration.
Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
---
V2: fixed up commit message and tool infos as requested by
Josh Triplett <josh@...htriplett.org>
Type-checking coccinelle spatches are being used to locate type
mismatches between function signatures and return values.
./kernel/rcu/tree.c:3538 WARNING: return of wrong type
int != bool,
Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y)
Patch is against 4.1-rc3 (localversion-next is -next-20150511)
kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index bcc5943..599550c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3516,7 +3516,7 @@ static int rcu_pending(void)
* non-NULL, store an indication of whether all callbacks are lazy.
* (If there are no callbacks, all of them are deemed to be lazy.)
*/
-static int __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
+static bool __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
{
bool al = true;
bool hc = false;
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists