linux-kernel - Re: [PATCH V2] rcu: change function declaration to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 08:37:31 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] rcu: change function declaration to bool

On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote:
> On Mon, 11 May 2015 17:10:59 +0200
> Nicholas Mc Guire <hofrat@...dl.org> wrote:
> 
> > rcu_cpu_has_callbacks() is declared int but is actually returning bool and
> > and as the function description states " * Return true if the specified 
> > CPU has any callback....", this probably should be a bool. All (3) 
> > call-sites currently treat it as bool so the declaration.
> > 
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> > ---
> > 
> > V2: fixed up commit message and tool infos as requested by 
> >     Josh Triplett <josh@...htriplett.org>
> > 
> > Type-checking coccinelle spatches are being used to locate type 
> > mismatches between function signatures and return values. 
> > ./kernel/rcu/tree.c:3538 WARNING: return of wrong type
> >                     int != bool, 
> > 
> > Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y)
> > 
> > Patch is against 4.1-rc3 (localversion-next is -next-20150511)
> 
> I think what Josh was saying is that all the above except for the "V2"
> should be above the signature. Everything between the "---" and the
> patch gets tossed out when committed into git.
> 
> Giving credit to coccinelle and even what branch and config was used
> for testing is something we want in the git change log history.

Yes, exactly.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/