linux-kernel - Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150511153822.GA27224@localhost>
Date:	Mon, 11 May 2015 17:38:22 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Niklas Cassel <niklas.cassel@...s.com>
Cc:	f.fainelli@...il.com, festevam@...il.com, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	johan@...nel.org, Niklas Cassel <niklass@...s.com>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe

On Mon, May 11, 2015 at 05:21:06PM +0200, Niklas Cassel wrote:
> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
> 
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
> 
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
> 
> Cc: stable <stable@...r.kernel.org> # 3.18+
> 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")

Looks like you forgot the "Fixes: " tag itself when updating.

> Signed-off-by: Niklas Cassel <niklass@...s.com>

Look good otherwise, feel free to add my

Reviewed-by: Johan Hovold <johan@...nel.org>

when resending (unless David wants to fix it up himself).

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/