linux-kernel - Re: [PATCH v2] net: ll_temac: Use one return statement instead of two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1505111747150.2393@hadrien>
Date:	Mon, 11 May 2015 17:48:31 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Michal Simek <michal.simek@...inx.com>
cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	Markus Elfring <elfring@...rs.sourceforge.net>
Subject: Re: [PATCH v2] net: ll_temac: Use one return statement instead of
 two

> > A coccinelle script might be rather more complicated
> > than the simpler grep above, but perhaps the script
> > could be a bit more complete as it could likely look
> > at more code indentation styles.
>
> Julia: Any comment?

Here is what I had in mind:

if (...) {
  ... when != goto l;
  return C;
}
return C;

C is a constant, to avoid that its value depends on the code in the ...

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/