linux-kernel - Re: [PATCH v3 05/22] posix-timers:Convert to the 64bit methods for the timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3090730.Lc4aTu6C4b@wuerfel>
Date:	Mon, 11 May 2015 18:30:52 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	y2038@...ts.linaro.org
Subject: Re: [PATCH v3 05/22] posix-timers:Convert to the 64bit methods for the timer_gettime syscall function

On Monday 11 May 2015 19:15:14 Baolin Wang wrote:
> +static int default_timer_get64(struct k_itimer *timr,
> +                              struct itimerspec64 *cur_setting64)
> +{
> +       struct itimerspec cur_setting;
> +       struct k_clock *kc = clockid_to_kclock(timr->it_clock);
> +
> +       kc->timer_get(timr, &cur_setting);
> +       return 0;
> +}

This function is unfortunately incorrect, because you never copy
the cur_setting value into cur_setting64.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/