linux-kernel - Re: [PATCH] block: Refine blk_abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5550DFD2.6090805@fb.com>
Date:	Mon, 11 May 2015 12:58:58 -0400
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@....de>,
	Bart Van Assche <bart.vanassche@...disk.com>
CC:	Shaohua Li <shli@...com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Stefan Haberland <stefan.haberland@...ibm.com>
Subject: Re: [PATCH] block: Refine blk_abort_request() documentation

On 05/11/2015 07:44 AM, Christoph Hellwig wrote:
> On Mon, May 11, 2015 at 01:20:00PM +0200, Bart Van Assche wrote:
>> Document when it is safe to call this function for blk-mq queues.
>
> Maybe we should move the queue_lock acquisition into blk_abort_request
> for the !blk-mq case?  libata and libsas already take it just around the
> call, an the usage in the dasd driver looks like it only needs
> the queue_lock for the blk_abort_request call as well.

I think so.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/