linux-kernel - Re: [PATCH] mmc:Add pointer cast to long for slave_id_rx and tx in the function, sh_mmcif_request_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1694173.4OOsIkYGBD@avalon>
Date:	Mon, 11 May 2015 20:28:24 +0300
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	ulf.hansson@...aro.org, ben.dooks@...ethink.co.uk,
	ykaneko0929@...il.com, laurent.pinchart+renesas@...asonboard.com,
	kouichi.tomita.yn@...esas.com, kuninori.morimoto.gx@...esas.com,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc:Add pointer cast to long for slave_id_rx and tx in the function, sh_mmcif_request_dma_one

Hello,

On Monday 11 May 2015 13:15:17 Nicholas Krause wrote:
> This adds a pointer cast to long in the function, sh_mmif_request_dma_one

I would use the uintptr_t type instead of long, as it has been designed for 
this purpose exactly.

> for the when assigning one of the variables slave_id_tx or slave_id_rx of
> the structure pointer,pdata to the void pointer, slave_data and the enum
> directon respectfully.

It's very nice to be respectful, but the commit message doesn't tell why this 
is needed. Something along the lines of "Cast integer to void * through 
uintptr_t to avoid compiler warning when compiling on 64bit platforms." would 
be more helpful.

> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/mmc/host/sh_mmcif.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 7eff087..e276558 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
> 
>  	if (pdata)
>  		slave_data = direction == DMA_MEM_TO_DEV ?
> -			(void *)pdata->slave_id_tx :
> -			(void *)pdata->slave_id_rx;
> +			(void *)(long)pdata->slave_id_tx :
> +			(void *)(long)pdata->slave_id_rx;
> 
>  	chan = dma_request_slave_channel_compat(mask, shdma_chan_filter,
>  				slave_data, &host->pd->dev,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/