[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150512070455.GB30476@gmail.com>
Date: Tue, 12 May 2015 09:04:55 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Josh Triplett <josh@...htriplett.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Michal Hocko <mhocko@...e.cz>,
Vladimir Davydov <vdavydov@...allels.com>,
Johannes Weiner <hannes@...xchg.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Andy Lutomirski <luto@...capital.net>,
Bertrand Jacquin <beber@...eeweb.net>,
"Luis R. Rodriguez" <mcgrof@...e.com>,
Iulia Manda <iulia.manda21@...il.com>,
Pranith Kumar <bobby.prani@...il.com>,
Clark Williams <clark.williams@...il.com>,
Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu
* Josh Triplett <josh@...htriplett.org> wrote:
> Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
> !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
> longer hidden with !EXPERT, but left it in the middle of the EXPERT
> menu. menuconfig stops putting config items under a submenu once it
> encounters an item that doesn't depend on the menu's config item, so
> this caused the remainder of the EXPERT menu to spill out into the
> containing menu around it. Fix by moving BPF_SYSCALL before the EXPERT
> menu, next to BPF.
>
> Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
> Signed-off-by: Josh Triplett <josh@...htriplett.org>
> ---
>
> Ingo, do you want to take this through -tip? Or should this go
> through some other tree?
I can pick it up, but -mm might be better suited for this, if you do:
> I'm also thinking about splitting the entire EXPERT menu into a
> separate Kconfig.expert and including it from init/Kconfig, to make
> it clear that everything in that menu should only be visible if
> EXPERT. Right now, the long EXPERT menu blends into the longer
> init/Kconfig, and issues like this happen every few kernel releases.
That's a good idea as well.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists