linux-kernel - Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 09:48:57 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Arnd Bergmann <arnd@...db.de>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device
 properties interface

Hi Bryan,

On Fri, May 8, 2015 at 7:43 PM, Bryan Wu <cooloney@...il.com> wrote:
> On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>> If GPIOLIB=n:
>>
>>     drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’:
>>     drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’
>>     drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast
>>
>> Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child()
>> for the !GPIOLIB case to fix this.
>
> This patch looks good to me. Do you mind merging it through LED tree
> with other 2 more LED patches?

Now we have an ack from Alex, that's fine for me. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/