linux-kernel - Re: [PATCH V2] x86: Allow built-in command line to work in early kernel init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 11:28:21 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Matthew Garrett <matthew.garrett@...eos.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>, x86@...nel.org,
	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg59@...eos.com>
Subject: Re: [PATCH V2] x86: Allow built-in command line to work in early
 kernel init


* Matthew Garrett <matthew.garrett@...eos.com> wrote:

> Any feedback on this?

So I worry about:

 - the fragmented nature of it: lots of non-obvious pieces of code 
   will now be scattered all around arch/x86/.

 - the crazy #ifdefs scattered around

 - the various pieces of data scattered around

... so while I don't mind the feature in principle, but it should be 
centralized much better IMHO, made Kconfig invariant at least in its 
fragmented callbacks, with only the very strictly boot method specific 
details spelled out explicitly.

I have not thought much about how to achieve that :-/

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/