linux-kernel - Re: [PATCH] cpufreq: arm_big_little: remove compile-time dependency on BL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5551C98D.6010104@arm.com>
Date:	Tue, 12 May 2015 10:36:13 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	Sudeep Holla <Sudeep.Holla@....com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jon Medhurst <tixy@...aro.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] cpufreq: arm_big_little: remove compile-time dependency
 on BL_SWITCHER



On 12/05/15 09:03, Sudeep Holla wrote:
>
>
> On 12/05/15 08:27, Viresh Kumar wrote:
>> On 11-05-15, 12:24, Sudeep Holla wrote:
>>> With the addition of switcher code, there's compile-time dependency on
>>> BL_SWITCHER to get arm_big_little driver compiling on ARM64. Since ARM64
>>
>> The Kconfig dependency isn't on the switcher but big.LITTLE, which
>> isn't defined for arm64. So, we need a bit of clarity here.
>>
>
> Right, we update accordingly.
>
>>> @@ -562,8 +580,7 @@ int bL_cpufreq_register(struct cpufreq_arm_bL_ops *ops)
>>>
>>>    	arm_bL_ops = ops;
>>>
>>> -	ret = bL_switcher_get_enabled();
>>> -	set_switching_enabled(ret);
>>> +	set_switching_enabled(bL_switcher_get_enabled());
>>
>> This change wasn't required.
>>
> Right, I thought ret is not used anywhere else and might produce
> warnings, which is wrong. I will revert it back.
>
Sorry replied too early, I have to retain it, or change it in
bL_cpufreq_unregister as the stub produces warning in one of the 2 call
sites since the return value is used in one place while discarded at
another.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/