linux-kernel - Re: [PATCH] alpha: Wire up missing syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 19:46:10 +0800
From:	Chen Gang <xili_gchen_5257@...mail.com>
To:	Michael Cree <mcree@...on.net.nz>, rth@...ddle.net,
	ink@...assic.park.msu.ru,
	"mattst88@...il.com" <mattst88@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-alpha@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] alpha: Wire up missing syscalls

On 05/12/2015 07:40 PM, Chen Gang wrote:
> On 05/12/2015 04:59 PM, Michael Cree wrote:
>> On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
>>> The related warnings:
>>>
>>>     CALL    scripts/checksyscalls.sh
>>>   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
>>>   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
>>>   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
>>>   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
>>>   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
>>
>> Chen: Have you tested the syscalls you have wired up?
>>
> 
> Sorry, no, I didn't.
> 
>> I have a suspicion that more is required to wire up the seccomp
>> syscall.  At least some of the other older architectures had to
>> implement some extra arch dependent support to implement the seccomp
>> syscall.  I don't know whether this is necessary or not on Alpha so
>> was wondering if this has been considered?
>>
> 
> At present, I guess (I did not test), it will lead to sys_ni_call(), so
> it is really only "wire up".
> 
>> Matt:  are you still feeding Alpha patches to Linus?  I suspect there
>> might be a few other patches other than this one submitted to
>> linux-alpha that should be applied.
>>
> 
> I found another issue when building alpha, I guess, it is valuable to be
> fixed (or there was already related patch but did not submitted?):
> 

It is only a building issue, not a bug (for me, it is valuable to be
fixed: only move "kts.tv_nsec *= 1000" to "if (tv) { ... }").

>   arch/alpha/kernel/osf_sys.c: In function ‘SyS_osf_settimeofday’:
>   arch/alpha/kernel/osf_sys.c:1028:14: warning: ‘kts.tv_nsec’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>     kts.tv_nsec *= 1000;
>                 ^
>   arch/alpha/kernel/osf_sys.c:1016:18: note: ‘kts’ was declared here
>     struct timespec kts;
>                     ^


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/