linux-kernel - Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <874mnid4z4.wl%kuninori.morimoto.gx@renesas.com>
Date:	Tue, 12 May 2015 00:18:59 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Nicholas Krause <xerofoify@...il.com>
CC:	<ulf.hansson@...aro.org>, <ben.dooks@...ethink.co.uk>,
	<ykaneko0929@...il.com>,
	<laurent.pinchart+renesas@...asonboard.com>,
	<kouichi.tomita.yn@...esas.com>, <linux-mmc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one


Hi

Nicholas Krause wrote:
> 
> This adds a cast to the variables,slave_id_rx and slave_id_rx
> to uintptr_t before casting to void* in order to avoid build
> warning on 64bit platforms for the function, sh_mmcif_request_dma_one.
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

# 1 open line is needed between log and Signed-off-by ?

>  drivers/mmc/host/sh_mmcif.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 7eff087..e276558 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
>  
>  	if (pdata)
>  		slave_data = direction == DMA_MEM_TO_DEV ?
> -			(void *)pdata->slave_id_tx :
> -			(void *)pdata->slave_id_rx;
> +			(void *)(uintptr_t)pdata->slave_id_tx :
> +			(void *)(uintptr_t)pdata->slave_id_rx;
>  
>  	chan = dma_request_slave_channel_compat(mask, shdma_chan_filter,
>  				slave_data, &host->pd->dev,
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/