linux-kernel - Re: [Jfs-discussion] [PATCH] fs: cleanup slight list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mw1a6lju.fsf@rasmusvillemoes.dk>
Date:	Tue, 12 May 2015 14:13:25 +0200
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Alexander Viro <viro@...iv.linux.org.uk>
Cc:	Boaz Harrosh <boaz@...xistor.com>,
	Dave Kleikamp <dave.kleikamp@...cle.com>,
	jfs-discussion@...ts.sourceforge.net,
	linux-ntfs-dev@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	codalist@...EMANN.coda.cs.cmu.edu, linux-mtd@...ts.infradead.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse

On Thu, Mar 19 2015, Dave Kleikamp <dave.kleikamp@...cle.com> wrote:

> On 03/19/2015 11:11 AM, Boaz Harrosh wrote:
>> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote:
>>> list_entry is just a wrapper for container_of, but it is arguably
>>> wrong (and slightly confusing) to use it when the pointed-to struct
>>> member is not a struct list_head. Use container_of directly instead.
>>>
>>> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
>>> ---
>>> Most of these predate git. If I'm the only one who has been confused
>>> by this in 10 years, maybe it's not worth the churn.
>>>
>> 
>> No you are not alone here. I have seen this once as well but did not have
>> the gumption to send a fix. (The sysv.h one)
>> 
>> I totally agree with this patch. (So many of them, bread crumbs of copy/paste
>> for you ;0)
>
> I'm sure that was the case with jfs.
>
>> 
>> Reviewed-by: Boaz Harrosh <boaz@...xistor.com>
>
> Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

Al, any chance you'd take this through the vfs tree?

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/