[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150512133620.GA24939@ulmo.nvidia.com>
Date: Tue, 12 May 2015 15:36:21 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Liu Ying <Ying.Liu@...escale.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
kernel@...gutronix.de, p.zabel@...gutronix.de,
shawn.guo@...aro.org, mturquette@...aro.org, airlied@...ux.ie,
andyshrk@...il.com, stefan.wahren@...e.com, a.hajda@...sung.com,
sboyd@...eaurora.org, daniel.vetter@...ll.ch,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per
pixel of MIPI DSI pixel format
On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote:
> Signed-off-by: Liu Ying <Ying.Liu@...escale.com>
This could use a commit message. Describe for example why this is useful
or when to use it.
> ---
> v9->v9.5:
> * Add kernel-doc for the new helper function to address Daniel Vetter's
> comment.
>
> v8->v9:
> * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository.
>
> v7->v8:
> * None.
>
> v6->v7:
> * None.
>
> v5->v6:
> * Address the over 80 characters in one line warning reported by the
> checkpatch.pl script.
>
> v4->v5:
> * None.
>
> v3->v4:
> * None.
>
> v2->v3:
> * None.
>
> v1->v2:
> * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function
> could be placed at the common DRM MIPI DSI driver.
> This patch is newly added.
>
> include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index f1d8d0d..cabc910 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev)
> return container_of(dev, struct mipi_dsi_device, dev);
> }
>
> +/**
> + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi
> + * pixel format
> + * @fmt: mipi dsi pixel format
> + *
> + * Return: The bits per pixel value for the mipi dsi pixel format on success or
> + * a negative error code on failure.
> + */
s/mipi dsi/MIPI DSI/, please.
Thierry
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists