linux-kernel - Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431442336.2884.57.camel@perches.com>
Date:	Tue, 12 May 2015 07:52:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Eugene Crosser <eugene.crosser@...ibm.com>,
	Frank Blaschka <frank.blaschka@...ibm.com>,
	Ursula Braun <ursula.braun@...ibm.com>
Cc:	Kashyap Desai <kashyap.desai@...gotech.com>,
	Sumit Saxena <sumit.saxena@...gotech.com>,
	Uday Lingala <uday.lingala@...gotech.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...gotech.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

On Tue, 2015-05-12 at 16:04 +0200, Rasmus Villemoes wrote:
> On Tue, Feb 10 2015, Kashyap Desai <kashyap.desai@...gotech.com> wrote:
> 
> > Acked-by: Kashyap Desai <kashyap.desai@...gotech.com>
> >
> >> -----Original Message-----
> >> From: Rasmus Villemoes [mailto:linux@...musvillemoes.dk]
> >> Sent: Friday, February 06, 2015 8:04 PM
> >> To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley
> >> Cc: Rasmus Villemoes; megaraidlinux.pdl@...gotech.com; linux-
> >> scsi@...r.kernel.org; linux-kernel@...r.kernel.org
> >> Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster
> >>
> >> There is currently no %po format extension, so currently the letters
> > "on" are
> >> simply skipped and the pointer is printed as expected (while missing the
> > word
> >> on). However, it is probably only a matter of time before someone comes
> > up
> >> with a %po extension, at which point this is likely to fail
> > spectacularly.
> >>
> >> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> 
> Any chance either this minimal fix or Joe's more thorough cleanup could
> get applied? There's still no %po extension, but there's certainly a lot
> of proposals for more %p extensions flying around LKML, so I still think
> the "only a matter of time" holds.

There's also this one with %pM6:
---
 drivers/s390/net/qeth_l2_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 0ea0869..dc783047 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -1420,8 +1420,8 @@ static void qeth_bridge_emit_host_event(struct qeth_card *card,
 			env[i] = str[i]; i++;
 		}
 		if (code & IPA_ADDR_CHANGE_CODE_MACADDR) {
-			snprintf(str[i], sizeof(str[i]), "MAC=%pM6",
-				&addr_lnid->mac);
+			snprintf(str[i], sizeof(str[i]), "MAC=%pM",
+				addr_lnid->mac);
 			env[i] = str[i]; i++;
 		}
 		snprintf(str[i], sizeof(str[i]), "NTOK_BUSID=%x.%x.%04x",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/