linux-kernel - Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 20:52:13 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Borislav Petkov <bp@...e.de>,
	Mark Rustad <mark.d.rustad@...el.com>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline

On Tue, 2015-05-12 at 22:14 +0600, Alexander Kuleshov wrote:
> Hi Andy,
> 
> 
> 2015-05-12 16:50 GMT+06:00 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:
> >
> > This one breaks kernel to work. You have to call setup_builtin_cmdline()
> > here.
> >
> >>       strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
> >>       *cmdline_p = command_line;
> >>
> 
> Why? The setup_builtin_cmdline will be called before setup_arch in the
> head{32, 64}.c,
> or I've missed something?

Yes, you missed the call here in *this* patch.

So, here is a trade off between smaller understandable changes and
bisectability. On one hand you may go like you did previously (one patch
for two changes), on the other — make it work after each patch applied
one-by-one.

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/