linux-kernel - Re: [RFC][PATCH] devicetree: Add hardware rng entry to qcom-apq8064.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55524BF8.1050200@codeaurora.org>
Date:	Tue, 12 May 2015 11:52:40 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	John Stultz <john.stultz@...aro.org>, linux-kernel@...r.kernel.org
CC:	Kumar Gala <galak@...eaurora.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	devicetree@...r.kernel.org
Subject: Re: [RFC][PATCH] devicetree: Add hardware rng entry to qcom-apq8064.dtsi

On 05/12/15 10:53, John Stultz wrote:
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index b3154c0..c760f2f 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -226,6 +226,13 @@
>  			};
>  		};
>  
> +		rng@...00000 {
> +			compatible = "qcom,prng";
> +			reg = <0x1A500000 0x200>;

This could be lowercase to match the rest of this file.

> +			clocks = <&gcc PRNG_CLK>;
> +			clock-names = "core";
> +		};
> +
>  		qcom,ssbi@...000 {
>  			compatible = "qcom,ssbi";
>  			reg = <0x00500000 0x1000>;

Otherwise looks good.

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/