linux-kernel - Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 22:00:13 +0200
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>>  				 */
>>  				skb_pull(sub_skb, SNAP_SIZE);
>> -				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN);
>> -				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN);
>> +				memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
>> +				       ETH_ALEN); /* Must be unaligned */
> 
> 
> Which part isn't aligned?  I think they both are.
> 
struct rtllib_rxb *prxb = prxbIndicateArray[j];

struct rtllib_rxb {
	u8 nr_subframes;
	struct sk_buff *subframes[MAX_SUBFRAME_COUNT == 64];
	u8 dst[ETH_ALEN]; // here
	u8 src[ETH_ALEN]; // here
} __packed;

Either I forgot alignment / packing rules or this fields are never aligned "by design".

If I remember correctly - I missed it in the first version as well, but then 
added BUG into ether_addr_copy().

Regards, 
Mateusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/